search

mgmonteleone / python-atlasapi

python package for MongoDB Atlas Cloud provider
Apache License 2.0
21 stars 22 forks source link

refactor "username" and password to "key" and "secret" to eliminate confusion #160

Closed mgmonteleone closed 1 year ago

mgmonteleone commented 1 year ago 
def __init__(self, user: str, password: str, group: str = None,
                 auth_method: Union[HTTPBasicAuth, HTTPDigestAuth] = HTTPDigestAuth):
        self.group = group

is misleading...

the term user should be replaced with key, and the term password to secret .

Idea from discussion #153

mgmonteleone commented 1 year ago

completed in PR #162 , will go to v3.