search

mgmonteleone / python-atlasapi

python package for MongoDB Atlas Cloud provider
Apache License 2.0
21 stars 22 forks source link

Additional cluster data broke sharded cluster #177

Closed gcoupelant closed 1 year ago

gcoupelant commented 1 year ago

Hello

In this MR: https://github.com/mgmonteleone/python-atlasapi/pull/157 you added a created_date attribute to the ClusterConfig class and updated the fill_from_dict class method accodingly. But you omitted to also update the ShardedClusterConfig class.

Because of that, some commands will fail when ran against a sharded cluster:

TypeError: ShardedClusterConfig.__init__() takes from 1 to 21 positional arguments but 22 were given

The 22nd positional argument being created_date.

Downgrading to version 2.0.6 "fixes" the issue for now 🙂

mgmonteleone commented 1 year ago

Thanks for letting me know, fixing now.

mgmonteleone commented 1 year ago

@gcoupelant , fixed and released in V3.0.1b5.