search

mgol / grunt-check-dependencies

Checks if currently installed npm dependencies are installed in the exact same versions that are specified in package.json
MIT License
15 stars 6 forks source link

Allow to continue after checking using an option #8

Closed yannickglt closed 9 years ago

yannickglt commented 9 years ago

With the following config, the task checks missing dependencies, eventually install them and continue running the end of the grunt task. options: packageManager: 'npm' install: true continue: true

mgol commented 9 years ago

I implemented this logic in this way because if a user loaded all their tasks and then runs grunt-check-dependencies (a common scenario, especially with plugins like load-grunt-tasks) then after updating packages still the old tasks will be invoked as they're already in memory.

So if I'm going to land this I'd like this option to be described as advanced, I'd like to have a mention that if you don't know all the consequences then don't enable it and I'd like to have the scenario I described above written in the README with an advice how to use it properly.

Do you want to do it? :)

yannickglt commented 9 years ago

Ok I understand. Do the modifications look sufficient?

mgol commented 9 years ago

Thanks and sorry for such a long wait! I've merged it and released 0.10.0.

yannickglt commented 9 years ago

Thank you too!