mgold / elm-socketio

[OLD] Socket.io wrapper for Elm.
BSD 3-Clause "New" or "Revised" License
47 stars 8 forks source link

File path is too long on windows #5

Closed bruno-cadorette closed 8 years ago

bruno-cadorette commented 8 years ago

When downloading the package on windows, I get the error message that the file path is too long. The problem is in example/node_modules/socket.io.

It would be nice if you could remove that example or just put it in another package (elm-socketio-example)

mgold commented 8 years ago

...Seriously, Microsoft?

I suppose I could include a package.json file so people would download the node modules themselves.

Do you have the exact text of the error?

bruno-cadorette commented 8 years ago

Do you approve of this plan? (y/n) y Downloading elm-lang/core Downloading mgold/elm-socketio

Error: failed with 'mgold-elm-socketio-ddd55d2/examples/node_modules/socket.io/node_modules/socket.io-client/node_modules/engine.io-client/node_modules/engine.io-parser/node_modules/arraybuffer.slice/package.json: openBinaryFile: does not exist (No such file or directory)' when sending request to http://github.com/mgold/elm-socketio/zipball/2.0.2/

mgold commented 8 years ago

How does that indicate that the filepath is too long?

bruno-cadorette commented 8 years ago

Oops sorry I got the wrong error, the funny things is that the error is different depending on the context, sometimes I get the earlier error, sometimes I get this one

To install mgold/elm-socketio I would like to add the following dependency to elm-package.json:

"mgold/elm-socketio": "2.0.2 <= v < 3.0.0"

May I add that to elm-package.json for you? (y/n) y

Some new packages are needed. Here is the upgrade plan.

  Install:
    mgold/elm-socketio 2.0.2

Do you approve of this plan? (y/n) y
Downloading mgold/elm-socketio

Error: failed with 'CreateDirectory "mgold-elm-socketio-ddd55d2\\examples\\node_modules\\socket.io\\node_modules\\engine.io\\node_modules\\engine.io-parser\\node_modules\\arraybuffer.slice": does not
exist (The filename or extension is too long.)' when sending request to
    <http://github.com/mgold/elm-socketio/zipball/2.0.2/>
mgold commented 8 years ago

Okay, I'll release a fix for this today or tomorrow.

mgold commented 8 years ago

Fix has been pushed to master. I'm going to let it sit for a few hours before releasing the package so I can see if there's anything else I want to include in the patch release.

bruno-cadorette commented 8 years ago

Thanks :)

mgold commented 8 years ago

2.0.3 is published. :tada: