sql-insert functionality initial

mgolokhov / dodroid

May the knowledge be with you!

MIT License

20 stars 12 forks source link

sql-insert functionality initial #34

Closed shiraeeshi closed 8 years ago

mgolokhov commented 8 years ago

Thank you for your contribution. You have done a lot of work, so I need some time to check and test the code before merging.

mgolokhov commented 8 years ago

A very good code. I like your DB normalisation and "True or False" question optimisation.

Some questions popped in my mind. When do we need to close Cursor and SQLiteDatabase? Are their any advantages in using rawQuery over query/insert/..?

shiraeeshi commented 8 years ago

"When do we need to close Cursor and SQLiteDatabase?" You're right, I've edited the code, committed to 'no-global' branch.
"Are their any advantages in using rawQuery over query/insert/..?" I'm not sure if I understood the question right, I use template query with question marks in place of parameters in the case when query will be invoked in a loop. I guess it's might be more efficient to have such a template query, but it's just a guess.

mgolokhov commented 8 years ago

Are their any advantages in using rawQuery over query/insert/..?"

There are two strategies:

create raw sql string and query it
use SQLiteDatabase.query() / SQLiteDatabase.insert() with the help of ContentValues() / and so on.

The former can be (may be not) a little bit faster. The latter is more secure (prevent sql injections).