Add FAB in the Topic Activity

[mgolokhov]

To use drawer every time is overkill.

[JaeW]

Was going to suggest this very thing. I like the idea of a FAB - just pick the topic and click the FAB. Elegant. Simple.

[JaeW]

Currently, in the navigation drawer menu, you're using a custom icon to begin the quiz (ic_lightning_sword.png). Is this the icon you want to use on the FAB, or do you want to go with a more standard icon like this or this as recommended in the Material Design guidelines?

[mgolokhov]

For consistency should be the same.

On Wed, Jun 8, 2016 at 12:36 AM, JaeW notifications@github.com wrote:

Currently, in the navigation drawer menu, you're using a custom icon to begin the quiz (ic_lightning_sword.png). Is this the icon you want to use on the FAB, or do you want to go with a more standard icon this https://materialdesignicons.com/%3Ethis%3C/a%3E%20or%20%3Ca%20href= are recommended in the Material Design guidelines?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mgolokhov/dodroid/issues/63#issuecomment-224422301, or mute the thread https://github.com/notifications/unsubscribe/AAR-cALgcR59uTvwchDT13N3jRpS3XRuks5qJeR6gaJpZM4IFquN .

[JaeW]

Agree on consistency issue. So current icon? or material design icon? I think a play button (right-pointing arrow) might be more intuitive, but am fine with whichever. Just wanted to point out material design guidelines. :)

[JaeW]

Added the FAB in my forked version. For consistency, I made the background color and attributes same as FAB in quiz. Using ic_lightning_sword.png didn't work on the FAB - it is not visible with the background color. Temporarily added a Material Design icon. Added onClickListener, but debating on how to access method createBackStack(intent) in DrawerBaseActivity. Perhaps create interface which DrawerBaseActivity implements? Not sure. Would like to hear your thoughts.

[mgolokhov]

First you have to sync with current state of remote branch. Next check function https://github.com/mgolokhov/dodroid/blob/fa5258271c60d2aac293e4f121631d0aa5c5ac83/app/src/main/java/doit/study/droid/activities/DrawerBaseActivity.java#L157

[JaeW]

So what happens if I have committed changes to my forked repo on GitHub but don't want to push them to your master? I didn't branch - oops. Still possible to simply pull your changes and abandon mine?

On Fri, Jun 10, 2016 at 1:09 AM, Maxim Golokhov notifications@github.com wrote:

First you have to sync with current state of remote branch https://help.github.com/articles/syncing-a-fork/. Next check function https://github.com/mgolokhov/dodroid/blob/fa5258271c60d2aac293e4f121631d0aa5c5ac83/app/src/main/java/doit/study/droid/activities/DrawerBaseActivity.java#L157

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mgolokhov/dodroid/issues/63#issuecomment-225101384, or mute the thread https://github.com/notifications/unsubscribe/AJ_JOEN3Uss9aBGdKhRsLhhmH2Lm54VBks5qKP9_gaJpZM4IFquN .

Janice Wildrick 314-651-4597

“There is no passion to be found playing small - in settling for a life that is less than the one you are capable of living.” -- Nelson Mandela

[mgolokhov]

You may try

git checkout master
git branch new-branch-to-save-current-commits
git fetch --all
git reset --hard origin/master

check link

[JaeW]

Deleted my fork. Re-forked. Lazy solution, but a solution nonetheless. Will branch before making changes in the future. Thanks.

[mgolokhov]

You may just clone in another folder, so not to loose your changes.

[JaeW]

Too late. Already done. Recreating changes ... good practice. On Jun 19, 2016 01:35, "Maxim Golokhov" notifications@github.com wrote:

You may just clone in another folder, so not to loose your changes.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mgolokhov/dodroid/issues/63#issuecomment-226982221, or mute the thread https://github.com/notifications/unsubscribe/AJ_JOCJMnqUFfFmsmx6U2fLHGc5XMq7Sks5qNOMmgaJpZM4IFquN .

[mgolokhov]