search

mgolokhov / dodroid

May the knowledge be with you!
MIT License
20 stars 12 forks source link

squid:S1192 - String literals should not be duplicated #82

Closed georgekankava closed 6 years ago

georgekankava commented 8 years ago

This pull request is focused on resolving occurrence of Sonar rule squid:S1192 - String literals should not be duplicated. This pull request removes 36 minutes of technical debt. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1192 Please let me know if you have any questions. George Kankava

mgolokhov commented 8 years ago

In this case it's not a constant, but a part of sql query. It can give some micro optimisations, but refactoring would be harder to maintain (in this particular case). Only profiler can give the real picture and with a new String Pool algorithms (Java 7 & 8) it may not be worth the effort.