search

mgomes / api_auth

HMAC authentication for Rails and HTTP Clients
MIT License
480 stars 147 forks source link

Avoid alias_method_chain #118

Closed mlarraz closed 8 years ago

mlarraz commented 8 years ago

This is deprecated as of Rails 5 (in favor of Module#prepend, which is only in Ruby 2+).

Since we still have to support Ruby 1.8, just create the aliases manually

fwininger commented 8 years ago

Thank you so much ! I work yesterday on the same commit, but don't have time to do the pull request ! Please @kjg, can you merge it.

awendt commented 8 years ago

I'd like to question our support for Ruby 1.8 once again, its support ended loooong time ago. People shouldn't be using it in production anymore.

@kjg What do you think?

fwininger commented 8 years ago

I agree with you. I think we can drop the support of ruby-1.8, ruby-1.9 to use more ruby synthax. Moreover, we can also drop the support of rails 2 and 3, to focus on rails 4 and 5.

kjg commented 8 years ago

I'll pull this in as well as #116 and make a new release, and then we can create a 2.x branch and then drop support for ruby 1.8 and older rails on the master branch. How does that sound?

packrat386 commented 8 years ago

If y'all are going to do that, you should make sure to include a restraint in the gemspec for certain versions of ruby. Also, although 2.0 came out relatively recently, it might be good to leave 2.x supporting what it currently supports and then have 3.0 drop support for some older frameworks.