search

mgomes / api_auth

HMAC authentication for Rails and HTTP Clients
MIT License
480 stars 147 forks source link

Add PATCH request type via copy-paste #142

Closed am-dmr closed 7 years ago

am-dmr commented 7 years ago

Hi!

In most of cases a PATCH request is similar to POST/PUT. And like POST/PUT, PATCH should carry data in request body. So, MD5 populate/check must be default behavior for PATCH requests.

mgomes commented 7 years ago

@am-dmr thanks for PR! Could you get the tests green when you get a chance? I'd love to get this merged in.

am-dmr commented 7 years ago

@mgomes ok. I've forgot tests with rails 2.

fwininger commented 7 years ago

@am-dmr sounds good !

@mgomes, I think a better way is to accept the PR to remove Rails 2 and don't add more exceptions in the code to support old rubies.

am-dmr commented 7 years ago

@fwininger I think that removing rails-2 and/or ruby-1.8 should bump version to 3.x.x

fwininger commented 7 years ago

@am-dmr, we work already on this #141

am-dmr commented 7 years ago

@mgomes I fixed code for rails 2. https://travis-ci.org/mgomes/api_auth/builds/219456687. But I think, that https://travis-ci.org/mgomes/api_auth/jobs/219456716 is impossible, because there is no %i() in ruby < 2.0.