search

mgomes / api_auth

HMAC authentication for Rails and HTTP Clients
MIT License
480 stars 147 forks source link

Resolve #152 and #125 #161

Closed fwininger closed 6 years ago

fwininger commented 6 years ago

This PR resolves #152 and resolves #125.

@kjg or @mgomes can you consider that ?

kjg commented 6 years ago

Looks good. Thanks so much! Can you please split out the travis / gemfile changes from the code changes and fix the failing spec?

fwininger commented 6 years ago

@kjg done!

I just remove the failing test because, it's no more possible to do a empty uri with RestClient. I try to fix that with Net::HTTP, but I have the same issue : 

Net::HTTP::Get.new('')
> ArgumentError: HTTP request path is empty
fwininger commented 6 years ago

I can't fix rubocop without #160. Please merge #160 before.