search

mgomes / api_auth

HMAC authentication for Rails and HTTP Clients
MIT License
480 stars 147 forks source link

patch - rest_client requests - ensure headers are written / read correct... #36

Closed nicoarbogast closed 10 years ago

nicoarbogast commented 10 years ago

Hi, Thank you for the gem and the maintenance ! There were still a few issues with handling the headers for RestClient requests. These small changes fixed it. Thank you in advance for integrating them. Best Nico

kjg commented 10 years ago

Why do these methods need to save headers when make_auth_header is the last part of sign! and takes care of saving everything? Do these other methods get used without make_auth sometimes?

nicoarbogast commented 10 years ago

Thanks @kjg, you're right. I agree we don't need these for the code to work. The idea was just to make sure that when we change a RestClient request headers we update its processed_headers that are the ones actually used by RestClient::Request when sending :execute.

kjg commented 10 years ago

I believe this might be fixed with https://github.com/mgomes/api_auth/commit/8de9ec93932a0ebd33aa456fa265a6489e4c9a16.

Can you please check if works for you and if not file new pull requests?