mgomes / api_auth

HMAC authentication for Rails and HTTP Clients
MIT License
480 stars 147 forks source link

Added support for Faraday::Request #64

Closed nathanhoel closed 9 years ago

nathanhoel commented 9 years ago

I previously made a pull request to directly support Typhoeus (#63) however we decided to use Typhoeus through it's Faraday adapter instead, thus I am back with another pull request. Faraday is actually probably a great addition for api-auth because it wraps many other HTTP clients libraries and probably more in the future. The standalone Typhoeus support still has it's merits as some people may want to use it directly instead of through Faraday.

https://github.com/lostisland/faraday

Faraday is an HTTP client lib that provides a common interface over many adapters (such as Net::HTTP) and embraces the concept of Rack middleware when processing the request/response cycle.

kjg commented 9 years ago

Looks good. Thanks so much for all the work!