mgonto / angularytics

The solution to tracking page views and events in a SPA with AngularJS
MIT License
630 stars 70 forks source link

Using $location.url() so we can track query parameters. #25

Closed richardbolt closed 10 years ago

richardbolt commented 10 years ago

$location.path() does not include query strings. Tracking query strings in the url is vital to being able to actually track traffic sources, and all that jazz.

All I did was switch out the one place there was $location.path() for $location.url(), and then run grunt bump and grunt.

mgonto commented 10 years ago

Makes complete sense. Thanks for the changes :)

mark0978 commented 10 years ago

When will this be released? Does not appear to be in 0.2.3.

bower info angularytics
bower angularytics#*            cached git://github.com/mgonto/angularytics.git#0.2.3
bower angularytics#*          validate 0.2.3 against git://github.com/mgonto/angularytics.git#*

{
  name: 'angularytics',
  version: '0.2.3',
  main: './dist/angularytics.min.js',
  description: 'The solution to tracking page views and events in a SPA with AngularJS',
  repository: {
    type: 'git',
    url: 'git://github.com/mgonto/angularytics.git'
  },
  dependencies: {
    angular: '*'
  },
  ignore: [
    'node_modules',
    'components',
    'lib'
  ],
  homepage: 'https://github.com/mgonto/angularytics'
}

Available versions:
  - 0.2.3
  - 0.2.2
  - 0.2.1
  - 0.2.0
  - 0.1.1
  - 0.1.0
mgonto commented 10 years ago

@mark0978 Hey, just released it :dancer:

Thanks!