Get working with java 12

[dylan-chong]

Fix a lot of errors with Java 12 and upgraded a lot of things. Still an error when you start up the game on my machine though. Tests pass however

error when starting up the game that I can't fix:

> ./gradlew run

> Task :run
Exception in thread "JavaFX Application Thread" java.lang.IllegalAccessError: class main.Main (in unnamed module @0x6ec824db) cannot access class com.sun.javafx.webkit.Accessor (in module javafx.web) because module javafx.web does not export com.sun.javafx.webkit to unnamed module @0x6ec824db
        at main.Main.lambda$start$2(Main.java:119)
        at javafx.base/com.sun.javafx.binding.ExpressionHelper$SingleChange.fireValueChangedEvent(ExpressionHelper.java:181)
        at javafx.base/com.sun.javafx.binding.ExpressionHelper.fireValueChangedEvent(ExpressionHelper.java:80)
        at javafx.base/javafx.beans.property.ReadOnlyObjectPropertyBase.fireValueChangedEvent(ReadOnlyObjectPropertyBase.java:74)
        at javafx.base/javafx.beans.property.ReadOnlyObjectWrapper.fireValueChangedEvent(ReadOnlyObjectWrapper.java:102)
        at javafx.base/javafx.beans.property.ObjectPropertyBase.markInvalid(ObjectPropertyBase.java:113)
        at javafx.base/javafx.beans.property.ObjectPropertyBase.set(ObjectPropertyBase.java:147)
        at javafx.web/javafx.scene.web.WebEngine$LoadWorker.updateState(WebEngine.java:1251)
        at javafx.web/javafx.scene.web.WebEngine$LoadWorker.dispatchLoadEvent(WebEngine.java:1366)
        at javafx.web/javafx.scene.web.WebEngine$PageLoadListener.dispatchLoadEvent(WebEngine.java:1231)
        at javafx.web/com.sun.webkit.WebPage.fireLoadEvent(WebPage.java:2513)
        at javafx.web/com.sun.webkit.WebPage.fwkFireLoadEvent(WebPage.java:2358)
        at javafx.web/com.sun.webkit.Timer.twkFireTimerEvent(Native Method)
        at javafx.web/com.sun.webkit.Timer.fireTimerEvent(Timer.java:83)
        at javafx.web/com.sun.webkit.Timer.notifyTick(Timer.java:64)
        at javafx.web/javafx.scene.web.WebEngine$PulseTimer.lambda$static$0(WebEngine.java:1192)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:428)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:389)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:427)
        at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)
        at javafx.graphics/com.sun.glass.ui.mac.MacApplication._enterNestedEventLoopImpl(Native Method)
        at javafx.graphics/com.sun.glass.ui.mac.MacApplication._enterNestedEventLoop(MacApplication.java:109)
        at javafx.graphics/com.sun.glass.ui.Application.enterNestedEventLoop(Application.java:509)
        at javafx.graphics/com.sun.glass.ui.mac.MacView._enterFullscreen(Native Method)
        at javafx.graphics/com.sun.glass.ui.View.enterFullscreen(View.java:785)
        at javafx.graphics/com.sun.javafx.tk.quantum.WindowStage.applyFullScreen(WindowStage.java:666)
        at javafx.graphics/com.sun.javafx.tk.quantum.WindowStage.setFullScreen(WindowStage.java:756)
        at javafx.graphics/javafx.stage.Stage.doVisibleChanged(Stage.java:1175)
        at javafx.graphics/javafx.stage.Stage$1.doVisibleChanged(Stage.java:186)
        at javafx.graphics/com.sun.javafx.stage.StageHelper.visibleChangedImpl(StageHelper.java:63)
        at javafx.graphics/com.sun.javafx.stage.WindowHelper.visibleChanged(WindowHelper.java:77)
        at javafx.graphics/javafx.stage.Window$12.invalidated(Window.java:1147)
        at javafx.base/javafx.beans.property.BooleanPropertyBase.markInvalid(BooleanPropertyBase.java:110)
        at javafx.base/javafx.beans.property.BooleanPropertyBase.set(BooleanPropertyBase.java:145)
        at javafx.graphics/javafx.stage.Window.setShowing(Window.java:1174)
        at javafx.graphics/javafx.stage.Window.show(Window.java:1189)
        at javafx.graphics/javafx.stage.Stage.show(Stage.java:273)
        at main.Main.start(Main.java:144)
        at javafx.graphics/com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$9(LauncherImpl.java:846)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runAndWait$12(PlatformImpl.java:455)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$10(PlatformImpl.java:428)
        at java.base/java.security.AccessController.doPrivileged(AccessController.java:389)
        at javafx.graphics/com.sun.javafx.application.PlatformImpl.lambda$runLater$11(PlatformImpl.java:427)
        at javafx.graphics/com.sun.glass.ui.InvokeLaterDispatcher$Future.run(InvokeLaterDispatcher.java:96)

[mgoo]

does it still work on java 8?

[dylan-chong]

I don't have a java 8 could you test it?

On 4/09/2019, at 12:09 PM, Andrew notifications@github.com wrote:

does it still work on java 8?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.