mgradwohl / VFI

The original code of Visual File Information that shipped with the Windows NT 4.0 Resource Kit.
Other
0 stars 0 forks source link

Multiple drop operations cause multiple dings #2

Open mgradwohl opened 10 years ago

mgradwohl commented 10 years ago
  1. Drop a folder with a lot of files in it on VFI
  2. Drop a folder with less files in it on VFI

Both drop operations work, but when the worker threads think they are done they ding a lot.

Is multiple drops safe? What's going on?

DanielSidhion commented 7 years ago

From a quick look, it seems like multiple threads are calculating the CRC, and when they're done they call CMyDoc::ChangeItemState which calls CMyDoc::SafeUpdateAllViews and then we ultimately end up in CMyListView::OnUpdate for each thread, playing the ding multiple times. If we're going to get rid of the current UI, we might want to look into separating UI code from core application code, and then make sure in the new UI we don't fall into this scenario.