search

mgrouchy / django-stronghold

Get inside your stronghold and make all your Django views default login_required
http://mikegrouchy.com/django-stronghold
MIT License
396 stars 47 forks source link

Add Django 2.0 support #68

Closed dvl closed 6 years ago

underyx commented 6 years ago

Django 2.x requires Python 3, so you can remove Python 2 + Django 2 combinations from the Travis build matrix.

dvl commented 6 years ago

All tests passing now by removing incompatible versions

underyx commented 6 years ago

I assume this is a nice time to ping @mgrouchy then to have this merged?

netman92 commented 6 years ago

@mgrouchy is it possible to merge this?

mgrouchy commented 6 years ago

Ill take a look at this, this evening and carve up a new release.

mgrouchy commented 6 years ago

sorry, merged another PR that caused conflicts here, if you can fix those in .travis.yml I will get this merged.

dvl commented 6 years ago

No problem, I'll take a look when I wake up

mgrouchy commented 6 years ago

@dvl thanks! :)

dvl commented 6 years ago

@mgrouchy I think it's fine now, please tell me if I'm missing something.

shacker commented 6 years ago

Nice timing - just had a Django 2 project update blocked by this issue - thanks and looking forward!

mgrouchy commented 6 years ago

@dvl I think this looks good! Thanks!

shacker commented 6 years ago

Works perfectly, thanks much.