mgsisk / inkblot

Inkblot is an elegant, fully responsive, highly customizable Webcomic-ready WordPress theme.
http://wordpress.org/themes/inkblot
45 stars 11 forks source link

Update breaks site #16

Closed lofrequency closed 11 years ago

lofrequency commented 11 years ago

It may be because I made a lot of modifications to inkblot, but after updating my site was pretty broken. My comic entries showed up twice with the associated blog post underneath both, and several style elements broke, causing my sidebar to be pushed to the bottom and my text to default to a larger size and haven no margins.

I'm going back to the old version because the site is incomprehensible right now, so I can't help by giving you something to look at.

lofrequency commented 11 years ago

Well, looks like I don't know what I'm doing. I imported a backup from just before I updated 20 minutes ago, and things are still broken.

ETA: Turns out it was the integration function that was suddenly working. Unticked that box in the settings and that fixed that... sidebar and styles still broken, tho.

lofrequency commented 11 years ago

Ah hm. Wordpress isn't able to locate my themes directory even though they are definitely there and I have my stylesheets open in my editor right now.

ETA: It seems to be just an error on the part of my Inkblot child theme. Still have no idea how to fix this right now, so I'm leaving it with the default theme for now.

lofrequency commented 11 years ago

broken

This is what I'm dealing with right now... the "id=post-webcomic" element is set at 1000px wide, even though it's actually set at "620px !important" in the child theme?

mgsisk commented 11 years ago

Where are you putting your styles? A recent update changed how Inkblot loads the various theme styles, so it's now preferable to put your own customizations into the custom.css file (this file is loaded after the Theme Customizer styles, to ensure your own styles take precedence). This keeps you from having to !important everything.

There's no #post-webcomic element; if you're actually assigning that width to an ID, like:

#post-webcomic { width: 620px !important; }

it won't work. There is, however, a post-webcomic class, so this:

.post-webcomic { width: 620px !important; }

ought to work.

lofrequency commented 11 years ago

Yeah, sorry I meant class.

So wait, does this render child themes redundant, or...?

mgsisk commented 11 years ago

Child themes are still preferable in most situations, but if the only thing you're customizing is Inkblot's styles you could just modify the custom.css file and forgo a child theme. Previously, Inkblot loaded three separate stylesheets:

  1. -/css/normalize.css
  2. style.css
  3. A dynamically generated stylesheet based on your Theme Customizer settings.

Because the Theme Customizer styles were always loaded last, any modifications you made to style.css (in Inkblot or a child theme) that the Theme Customizer could also style required the !important rule. Now, Inkblot only loads a single, dynamically generated stylesheet that's a composite of four sources:

  1. -/css/normalize.css
  2. style.css
  3. Your Theme Customizer settings.
  4. custom.css

The unified stylesheet is constructed in that order, so any rules in custom.css will take precedence over anything else, even your Theme Customizer settings, without the need to use !important.

lofrequency commented 11 years ago

A few things I'm noticing as I continue to try and fix this:

It seems like there are changes I'm making in custom.css that will only take if I go into the visual customizer via WP itself and change them there now. Sidebar width and background color so far only work that way for me.

And two, all of my front page links that had "border-radius" and color transition no longer have those styles applied to them?

mgsisk commented 11 years ago

I couldn't say what's causing those issues, unfortunately; there haven't been any changes in Inkblot's actual stylesheet or the structure of the theme, just how it loads stylesheets.

Edit: Actually, if you were previously using an @import rule in your child theme it won't work anymore (which might explain some of the issues). You'll want to copy the entirety of Inkblot's style.css file into the child themes style.css file (minus the header, of course), and then put your styles in the child themes custom.css file (if you're using a child theme).

lofrequency commented 11 years ago

I really wish I had another lead as to what might be doing this, but the only thing that changed was the theme update. I updated wordpress shortly before and saw that my site was exactly the same before updating Inkblot. I haven't touched the CSS itself in several weeks prior to this.

ETA: This is all inkblot/custom.css styles I'm using now, so no @import.

mgsisk commented 11 years ago

Looking at your generated stylesheet, it appears that all of Inkblot's default styling is duplicated in custom.css, which is not a good idea (I don't now how it got there, but it's appearing below the theme customizer styles so I'm guessing that's where it is). That might be the cause of some of the style issues. I also noticed there are a few references to the #main element, which actually doesn't exist anymore; any reference to #main should be replaced with main (this is the only structural change to the theme; apologies for missing that one).

mgsisk commented 11 years ago

It looks like the generated stylesheet still has a bunch of !important rules (apart from duplicating nearly all of Inkblot's default styles). Assuming these were removed from your themes custom.css file I can only assume there's some weird caching going on somewhere.

lofrequency commented 11 years ago

Ok so... going through my custom.css file and deleting all the stuff that wasn't specifically changed from the source stylesheet, deleting the !important rules, and adjusting the padding/margins seems to have fixed most of my issues (there's something weird going on with the right margin when I set all padding/margins to 0 for the main element).

My archived thumbnails are lookin funny now, but I'll post that in the support section. Thanks~