search

mgsloan / store

Fast binary serialization in Haskell
MIT License
109 stars 35 forks source link

Serialization roundripping of Template Haskell datatypes disabled due to Bytes' Eq instance #150

Open mgsloan opened 4 years ago

mgsloan commented 4 years ago

The Bytes type in template-haskell-2.16.0.0 uses derived Eq instances, which uses pointer equality, even though it is semantically similar to ByteString. This causes the serialization roundtrip tests to fail for some Template Haskell types, so I have disabled those tests. This issue tracks re-enabling them if this is fixed upstream.

RyanGlScott commented 4 years ago

Is there an upstream GHC issue about this?

mgsloan commented 4 years ago

There is not, but I just added a comment to an issue which seems to be collecting a list of gnarlyness about Bytes - https://gitlab.haskell.org/ghc/ghc/issues/16457#note_263611