search

mgsloan / store

Fast binary serialization in Haskell
MIT License
109 stars 35 forks source link

test/Data/StoreSpec.hs: tweak for network-3.1 #159

Closed trofi closed 3 years ago

trofi commented 3 years ago

On networt-3.1 testsuite fails build on duplicate instance definition for Bounded PortNumber:

test/Data/StoreSpec.hs:105:10: error:
    Duplicate instance declarations:
      instance Bounded PortNumber
        -- Defined at test/Data/StoreSpec.hs:105:10
      instance Bounded PortNumber
        -- Defined in ‘network-3.1.2.1:Network.Socket.Types’

The change uses network's instance if available.

mgsloan commented 3 years ago

Thanks for reporting! I actually interpreted this as an issue rather than a PR when reading my email, so went ahead and fixed this, and included the fix in store-0.7.11.

I don't think the constraint in your change is correct. It has version 3.1.0, but network-3.1.1.0 does not have the bounded instance: http://hackage.haskell.org/package/network-3.1.1.0/docs/Network-Socket.html#t:PortNumber

trofi commented 3 years ago

Thank you!