search

mgsloan / store

Fast binary serialization in Haskell
MIT License
109 stars 35 forks source link

Support for GHC 9? #160

Closed ranjitjhala closed 3 years ago

ranjitjhala commented 3 years ago

Hi @mgsloan,

Can you give me a sense of any plans to update store to work with ghc 9?

I recently switched liquidhaskell from binary to store -- and it was awesome -- in the blink of an eye, store was deserializing files that took binary literally hours (!)

Unfortunately, it turns out that it breaks our ghc9 build. So am wondering what your plans are, e.g. whether its doubtful in the short term, or if I should try to send a patch or, if its already in the works?

Thanks so much!

mgsloan commented 3 years ago

Awesome, I'm glad you've found store to be helpful for liquidhaskell! I have not not started work on a patch, but I can try to write one soonish. I will comment here if I start working on it. In the meantime, I'd gladly merge a PR adding support for ghc 9

On Mon, Aug 9, 2021 at 3:34 PM Ranjit Jhala @.***> wrote:

Hi @mgsloan https://github.com/mgsloan,

Can you give me a sense of any plans to update store to work with ghc 9?

I recently switched liquidhaskell from binary to store -- and it was awesome -- in the blink of an eye, store was deserializing files that took binary literally hours (!)

Unfortunately, it turns out that it breaks our ghc9 build. So am wondering what your plans are, e.g. whether its doubtful in the short term, or if I should try to send a patch or, if its already in the works?

Thanks so much!

  • Ranjit.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mgsloan/store/issues/160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFQKWDAI5MU6H46KFFQWTT4BCVVANCNFSM5B23KRMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

facundominguez commented 3 years ago

I made a try in #161.

ranjitjhala commented 3 years ago

Wow, that's awesome thank you @facundominguez !!!

Shall we update the LH cabal.ghc9.project to get your version of store until it is pulled into the mainline, put on hackage etc?

mgsloan commented 3 years ago

Thanks @facundominguez - this is now released on hackage as version 0.7.12 :)

ranjitjhala commented 3 years ago

wow, thank you so much @facundominguez and @mgsloan !!!

mgsloan commented 3 years ago

Glad it's finding use in Liquid Haskell! Such a cool project!

https://github.com/mgsloan/store/blob/master/src/System/IO/ByteBuffer.hs uses Liquid Haskell to verify some memory safety constraints :)

On Mon, Aug 16, 2021, 17:25 Ranjit Jhala @.***> wrote:

wow, thank you so much @facundominguez https://github.com/facundominguez and @mgsloan https://github.com/mgsloan !!!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/mgsloan/store/issues/160#issuecomment-899882189, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFQKVHZBBXUBLJA3PBUKDT5GM7NANCNFSM5B23KRMQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .