Constrain vector <0.13 for store's sake.

mgsloan / store

Fast binary serialization in Haskell

MIT License

109 stars 35 forks source link

Constrain vector <0.13 for store's sake. #171

Closed philderbeast closed 2 years ago

philderbeast commented 2 years ago

I need to constrain vector < 0.13 in order to build store otherwise I get errors like:

src/Data/Store/Internal.hs:824:3: error:
    • No instance for (Store (Data.Vector.Unboxed.Base.Vector b))
        arising from a use of ‘peek’

Looking at vector-0.13 release notes, this is the breaking change:

Remove redundant Storable constraints on to/from ForeignPtr conversions: #394

I first encountered this on https://github.com/ucsd-progsys/liquid-fixpoint/pull/609

mgsloan commented 2 years ago

Thanks for the PR!

Instead of adding this upper bound, I'm fixing this instore-0.7.16 by skipping generation of these instances which aren't very useful.

This actually is not caused by a breaking change in vector - vector#378. TH allows you to reify information about other packages in such a way that internal changes can cause breakage.