Use cryptohash-sha1 instead of the deprecated cryptohash

mgsloan / store

Fast binary serialization in Haskell

MIT License

109 stars 35 forks source link

Use cryptohash-sha1 instead of the deprecated cryptohash #175

Closed amesgen closed 11 months ago

amesgen commented 1 year ago

also drops several transitive dependencies like cryptonite, memory and basement

Closes #52

amesgen commented 1 year ago

The CI failures look unrelated FTR, but maybe it is as easy as regenerating the Haskell-CI config, should I do that in this PR?

mgsloan commented 1 year ago

Sure, regenerated CI config would be appreciated, thanks!

Also thanks for the overall change, it particularly makes sense as the sha1 is only used by store at compile time, so that mitigates most concerns about differences in speed.

amesgen commented 1 year ago

Pushed, CI should work now:

Dropped GHC <8.4 as th-utilities does not compile there due to https://github.com/fpco/th-utilities/pull/16.
Added GHC 9.2 and 9.4; Cabal does not find a plan for 9.6 yet due to e.g. https://github.com/fpco/weigh/issues/49.
Update hlint to 3.5.
Fixed a compilation failure with time >= 1.11; #164 only fixed the library part.

amesgen commented 1 year ago

Anything I could do to move this forward?

mgsloan commented 11 months ago

Argh, sorry for the huge delay! Somehow got buried in my email.

Thanks for all the fixes!

mgsloan commented 11 months ago

Fixes included in store-0.7.18, store-core-0.4.4.6, store-streaming-0.2.0.5