mgsloan / store

Fast binary serialization in Haskell
MIT License
109 stars 35 forks source link

0.7.17 package on Hackage does not include fix for time 1.11 #177

Closed Vekhir closed 1 year ago

Vekhir commented 1 year ago

Hi @mgsloan, When building the new version 0.7.17, I still got the same error as in #176 which got fixed in #175. Looking at the source over at Hackage (test/Data/StoreSpec.hs), we can see that the fix is somehow missing:

#if MIN_VERSION_time(1,11,0)
import qualified Data.Time.Calendar.Quarter as Time
#endif

whereas it should be (and is in this repo):

#if MIN_VERSION_time(1,11,0)
import qualified Data.Time.Calendar.Quarter as Time
import qualified Data.Time.Calendar.WeekDate as Time
#endif

Also, there is no changelog for 0.7.17, but that's minor.

-- Vekhir

mgsloan commented 1 year ago

Thanks @Vekhir ! I think I hadn't noticed that my git pull was incomplete when uploading the packages. Uploaded new ones with incremented versions

Vekhir commented 1 year ago

Works now. Thank you!