search

mgsloan / todoist-shortcuts

Browser extension which adds comprehensive keyboard shortcuts to Todoist, beyond what is offered by Todoist itself
MIT License
313 stars 23 forks source link

Missing "g" shortcuts for pinned filters in Beta #162

Closed BrunoGomesCoelho closed 3 years ago

BrunoGomesCoelho commented 3 years ago

The latest version of Todoist Beta (9342) seems to not suggest "g" shortcuts on any pinned filters:

image

Strangely, even does it doesn't show up, the shortcuts do work (ie, "g df" does take me into my "Daily Focus") - There is a error in the console associated, pasted at the end;

The non beta version (1053) does not seem to have this problem and works as expected: image

Beta version error, on Firefox 81.0.2, Linux Mint:

todoist-shortcuts: Couldn't figure out text for 
<li id="filter_team_inbox" class="filter" data-id="2176175280" data-track="navigation|team_inbox"> getStack@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:3519:13
error@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:3510:15
setupNavigate/<@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:2836:16
withTag@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:3627:8
setupNavigate@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:2788:14
navigate/</unregisterListener<@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:885:22
MutationCallback*registerMutationObserver@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:1831:20
navigate/<@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:884:56
withId@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:3600:14
navigate@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:879:11
callBinding/<@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4253:32
d@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4235:3326
o/m._handleKey@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4235:4729
o.prototype.handleKey@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4235:1718
o/m._handleKeyEvent@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4235:4972
o.prototype.handleKeyEvent@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4235:804
genericKeyHandler@moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4326:24
 Consider reporting this as an issue to http://github.com/mgsloan/todoist-shortcuts vendor.3adf61974e195b2b79fd.js:1:455434
    h https://d3ptyyxy2at9ui.cloudfront.net/assets/vendor.3adf61974e195b2b79fd.js:1
    error moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:3513
    setupNavigate moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:2836
    withTag moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:3627
    setupNavigate moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:2788
    unregisterListener moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:885
    (Async: MutationCallback)
    registerMutationObserver moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:1831
    navigate moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:884
    withId moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:3600
    navigate moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:879
    callBinding moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4253
    d moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4235
    _handleKey moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4235
    handleKey moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4235
    _handleKeyEvent moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4235
    handleKeyEvent moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4235
    genericKeyHandler moz-extension://8c807e6f-871d-4be3-8689-bff78a8e034c/todoist-shortcuts.js:4326

PS: Thank you for developing this amazing extension!

mgsloan commented 3 years ago

Thanks for the report! Looks like Todoist is nesting <a> elements under <ul> instead of using <li> like it used to, which is pretty much plain wrong. I've emailed my Todoist development contact, I'm hoping to not need to hack around this.

I'm guessing by the "shallow" filter / label that you've read / listened to some Cal Newport stuff?

mgsloan commented 3 years ago

Ah, looks like standard todoist was just updated with this change. I went ahead and hacked around it, wasn't so bad.

BrunoGomesCoelho commented 3 years ago

Awesome, thanks! :)

PS: Nope, haven't read the book itself but it's on my backlog, but a lot of people have distilled the knowledge and that's where I picked up the ideas from.

BrunoGomesCoelho commented 3 years ago

It seems like todoist again decided to change this, in Beta version 9355 the pinned filters no longer show but on the non beta they're still showing (v1053);

I don't seem to be able to re-open the issue so just commenting on it and mentioning you @mgsloan

mgsloan commented 3 years ago

Thanks for reporting! Fixed in version 120.