search

mgsloan / todoist-shortcuts

Browser extension which adds comprehensive keyboard shortcuts to Todoist, beyond what is offered by Todoist itself
MIT License
313 stars 23 forks source link

New task view (experimental feature) doesn't work with todoist-shortcuts #204

Closed Qu3cus closed 2 years ago

Qu3cus commented 2 years ago

This is just a heads up that the extension currently doesn't work with the task view that Todoist is testing as an experimental feature at the moment. Everything I've tested works just fine in the main interface, whether or not the new task view option is checked, it just doesn't work in the experimental task view itself.

Obviously I wouldn't expect compatibility with an unfinished feature, and chasing around trying to integrate with a feature that isn't yet complete would be a futile exercise, so this is more of an advance warning of a compatibility-breaking update that might be coming down the line at some point.

mgsloan commented 2 years ago

Thanks for letting me know! Is the experimental task view visible on beta.todoist.com?

On Mon, Feb 28, 2022 at 8:31 AM Qu3cus @.***> wrote:

This is just a heads up that the extension currently doesn't work with the task view that Todoist is testing as an experimental feature at the moment. Everything I've tested works just fine in the main interface, whether or not the new task view option is checked, it just doesn't work in the experimental task view itself.

Obviously I wouldn't expect compatibility with an unfinished feature, and chasing around trying to integrate with a feature that isn't yet complete would be a futile exercise, so this is more of an advance warning of a compatibility-breaking update that might be coming down the line at some point.

— Reply to this email directly, view it on GitHub https://github.com/mgsloan/todoist-shortcuts/issues/204, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFQKS5T3X77JICLULFMXLU5OINHANCNFSM5PRNE73Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you are subscribed to this thread.Message ID: @.***>

Qu3cus commented 2 years ago

Sorry - never saw the notification for this reply - from beta.todoist.com you need to go to the "advanced" pane in the settings, check "experimental features", then check "new task view"

mgsloan commented 2 years ago

No worries! That's interesting, I do not see a "new task view" checkbox

image

Qu3cus commented 2 years ago

According to a knowledge base article from todoist you might have to update after enabling experimental features to see the features available to test. It also looks like "experimental features" has replaced the beta programme, so I imagine beta.todoist.com doesn't do anything additional any more (I hadn't realised this myself).

https://todoist.com/help/articles/how-to-test-experimental-features

mgsloan commented 2 years ago

Ah, interesting, thanks! I think somehow I was on beta.todoist.com and the new task view toggle wasn't in the settings there. I do see it on the main todoist.com

On Mon, Apr 4, 2022 at 8:33 AM Qu3cus @.***> wrote:

According to a knowledge base article from todoist you might have to update after enabling experimental features to see the features available to test. It also looks like "experimental features" has replaced the beta programme, so I imagine beta.todoist.com doesn't do anything additional any more (I hadn't realised this myself).

https://todoist.com/help/articles/how-to-test-experimental-features

— Reply to this email directly, view it on GitHub https://github.com/mgsloan/todoist-shortcuts/issues/204#issuecomment-1087635951, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAFQKVHMXHV5DP5A43XOKLVDL4UPANCNFSM5PRNE73Q . You are receiving this because you commented.Message ID: @.***>

mgsloan commented 2 years ago

The new DOM has obfuscated class names so it would be challenging to bind keyboard shortcuts to it. As such, I'm deleting the special handling of task view, and instead falling back on native Todoist keyboard shortcuts for the task view. This change is included in version 147

error9900 commented 2 years ago

This change is a little rough...

Now we've got a situation where Shift + T is schedule by editing text in the list view, but Remove due date in task view...so it's now very easy to accidentally remove a due date in task view...

Might make more sense to just scrap scheduling from the extension altogether rather than trying to memorize and work with different, conflicting shortcuts, based on your view...

mgsloan commented 2 years ago

Makes sense! I forgot that the old task view still exists (I was used to the beta.todoist.com url instead of the new experimental toggle in settings).

In version 148, I've brought back the old keybindings in the meantime, and it now uses the native shortcuts for the experimental task view.

Hopefully by the time the new task view becomes default it will be more viable to bind shortcuts to it.

mgsloan commented 2 years ago

I've fixed this in version 149! Some keybindings will only work in the english translation, unfortunately.

mdbraber commented 1 year ago

With Experimental Features turned on in v2953 the priority shortcuts are broken (because of different class names). Is this also the case for other users? I've switched off Experimental Features for now.

An easy workaround for this seems to be to use clickTaskMenu instead of the clickTaskEdit code like such: 

clickTaskMenu(mutateCursor, 'task-overflow-menu-priority-' + level, false);
fabiocpn commented 1 year ago

With Experimental Features turned on in v2953 the priority shortcuts are broken (because of different class names). Is this also the case for other users? I've switched off Experimental Features for now.

I can confirm. "Experimental features" is breaking the shortcut to change priorities.

mgsloan commented 1 year ago

Thanks for reporting! Happily the fix is simple. I opened #233 to track it.