search

mgsloan / todoist-shortcuts

Browser extension which adds comprehensive keyboard shortcuts to Todoist, beyond what is offered by Todoist itself
MIT License
313 stars 23 forks source link

Shortcuts to set priority in list view not working #207

Closed error9900 closed 2 years ago

error9900 commented 2 years ago

Extension: v144. Todoist Web: v2055 Browser: Google Chrome

Seems maybe a recent update to Todoist broke using the number keys to set priority level in the list view? It still works fine in the task view.

EDIT: They work if I disable the Todoist Shortcuts extension and just use built-in Todoist keyboard shortcuts, which I think rules out another extension or Chrome interfering?

EDIT: This might help with troubleshooting: If I select multiple tasks, then hit 1, it opens the bulk Priority change drop-down at the top of the window (but doesn't actually change the Priority level).

mgsloan commented 2 years ago

Thanks for reporting! Fixed it in version 145.

mdbraber commented 2 years ago

With extension v149 on Firefox 101 (macOS Monterey) in list view the priority shortcuts (1, 2, 3, 4) set the priority, but also open the edit mode (they don't when disabling the Todoist Shortcuts extension). This prevents from quickly setting priorities like was possible previously

mdbraber commented 2 years ago

Using v2145 (beta) I was able to fix this changing https://github.com/mgsloan/todoist-shortcuts/blob/master/src/todoist-shortcuts.js#L622 from '.task_editor__form_actions button[type="submit"]', to 'div[data-testid="task-editor-action-buttons"] button[type="submit"]', Not sure if this is a problem only with the beta mode?

Fricounet commented 2 years ago

For information, I have the same issue on Chrome version 102.0.5005.61 (MacOS Monterey). And @mdbraber fix solves the issue for me too. For now, I have not found any unwanted side effect with the fix.

mgsloan commented 2 years ago

Thanks for the fix info! Will be included in version 150 which will be released soon.