search

mguessan / davmail

DavMail POP/IMAP/SMTP/Caldav/Carddav/LDAP Exchange and Office 365 Gateway - Synced with main subversion repository at
http://davmail.sourceforge.net
GNU General Public License v2.0
582 stars 86 forks source link

Fixes #309, timezone offsets can have seconds component #310

Closed br0xpl closed 1 year ago

br0xpl commented 1 year ago

Fixes #309 , timezone offsets can have seconds component

esabol commented 1 year ago

@br0xpl : Typo in PR title. Change "compoment" to "component".

Kenny2github commented 1 year ago

Thank you with all my heart. This issue has been blocking me from putting my tests in my calendar for days. The user-facing error that this issue causes is also completely opaque - DavMail says Can't find resource for bundle java.util.PropertyResourceBundle, key (timezone offset with seconds) for every event created in Thunderbird 115. If you create a bunch of events before the calendar syncs, it gives you a whole bunch of the same notification at once. Hopefully this comment helps someone searching for the same thing.

Building and installing this PR fixed the issue. Steps:

  1. Clone and checkout this PR.
  2. Follow the build steps here: https://davmail.sourceforge.net/build.html
  3. The installers will be built in the dist directory - use the one appropriate for your operating system.
  4. If creating events works at this point, you're done!
  5. If you get a further ClassNotFoundException, O365Interactive authentication does not work in your build and you will have to:
    1. Switch to O365Manual instead.
    2. If you are using a urn: redirect URI like I was to pretend to be Outlook, when clicking "Continue" to confirm that it is Outlook you will not navigate anywhere but instead your browser will produce a console error containing the URN it was trying to navigate you to. Otherwise look at the URL you were redirected to.
    3. Copy the value of the ?...code=THIS PART parameter and provide it to DavMail.
br0xpl commented 1 year ago

Thank you with all my heart. This issue has been blocking me from putting my tests in my calendar for days. The user-facing error that this issue causes is also completely opaque - DavMail says Can't find resource for bundle java.util.PropertyResourceBundle, key (timezone offset with seconds) for every event created in Thunderbird 115. If you create a bunch of events before the calendar syncs, it gives you a whole bunch of the same notification at once. Hopefully this comment helps someone searching for the same thing.

Building and installing this PR fixed the issue. Steps:

1. Clone and checkout this PR.

2. Follow the build steps here: https://davmail.sourceforge.net/build.html

3. The installers will be built in the `dist` directory - use the one appropriate for your operating system.

4. If creating events works at this point, you're done!

5. If you get a further `ClassNotFoundException`, O365Interactive authentication does not work in your build and you will have to:

6. Switch to O365Manual instead.

7. If you are using a `urn:` redirect URI like I was to pretend to be Outlook, when clicking "Continue" to confirm that it is Outlook you will not navigate anywhere but instead your browser will produce a console error containing the URN it was trying to navigate you to. Otherwise look at the URL you were redirected to.

8. Copy the value of the `?...code=THIS PART` parameter and provide it to DavMail.

If you want to have the class interactive you need to build the davmail with java.fx sdk. If using sdkman you can simply install and use it this way:

sdk install java 8.0.382.fx-zulu
sdk use java 8.0.382.fx-zulu

Then build in the same terminal davmail, and you won't have the ClassNotFound anymore.

mguessan commented 1 year ago

Thanks for your contribution, can you please check my alternative solution ?