mguessan / davmail

DavMail POP/IMAP/SMTP/Caldav/Carddav/LDAP Exchange and Office 365 Gateway - Synced with main subversion repository at
http://davmail.sourceforge.net
GNU General Public License v2.0
576 stars 85 forks source link

feature request: only open one browser window at a time #311

Closed floatious closed 1 year ago

floatious commented 1 year ago

Hello Mickaël,

Thank you very much for your work on davmail. I use it daily.

I use davmail with: davmail.mode=O365Interactive

When I wake up, and the remote connection has timed out (a new 2FA auth is needed), I am greeted by a lot of paste URL windows: davmail

It would be nice if davmail wouldn't open a new paste URL window, if there was already a paste URL window open.

mguessan commented 1 year ago

Well the real issue is network down detection: currently it assumes authentication failed when it's only a network issue. Need to investigate this.

Edit: unable to reproduce, at least on windows, the manual code window is a dialog so only one appears at any time Edit 2: maybe related to the fact that you have O365Interactive setup but JFX not available => failover to O365Manual

Tried to fix this in trunk, in the mean time you may also try to switch to O365Manual explicitly

floatious commented 1 year ago

You are correct, I do not have JFX installed.

I can confirm that switching to O365Manual explicitly does solve the problem even without the recent davmail changes in trunk. (I'm using https://copr.fedorainfracloud.org/coprs/mguessan/davmail 6.1.0-3.1)

For some reason, when I build trunk locally $ ant build and run davmail using the same config as I normally use, I get: IMAP command 'LOGIN ' returned an error: NO LOGIN failed

(The exact same config works fine with 6.1.0-3.1 from your copr.)

mguessan commented 1 year ago

Would need more details from the logs, but probably related to some dependency issue (regarding openjdk versions).

Let's close this one as it appears fixed for you.