Closed timon-schelling closed 6 days ago
could this be related? https://github.com/mgunyho/tere/issues/90
Thanks! I'll look at the PR later today.
That's strange with the build errors. I tried now on master with rustc 1.77.1 (7cf61ebde 2024-03-27) (on Fedora 40) and it worked fine. I'll try to update rustc and see if it fails after that.
The failure of test_case_sensitive_mode_change
indeed seems to be the same as #90, and it's still a mystery to me.
The tests work fine for me also on rustc 1.81.0 (eeb90cda1 2024-09-04) (although I get a couple of new warnings).
I tried it on GitHub code space and had the same problems like I described
Do you have suggestions on how to move forward? #90 seems to be environment dependent, as a test that should not be. On NixOS I'm able to build and run all tests. See https://github.com/timon-schelling/timonos/blob/7ed1566c035a98bcec317974698ff6f0060e70ae/overlays/tere/overlay.nix I'm really confused.
Hi, I checked your code and the PR looks good! Thanks for also including the tests. Could you please
develop
(that branch already has the update of textwrap to 0.16, although I couldn't reproduce the compilation issue you had) andCHANGELOG.md
?I'll then make a new release over the weekend.
The mysterious failling test is the same as #90 so we can leave that for the future.
Adds a
--skip-first-run-prompt
flag. "Disables the welcome message shown on the first launch of tere, which prompts the user to update their shell configuration for proper directory changing functionality. Use this flag if you have already configured your shell or want to bypass the prompt for other reasons."See https://github.com/timon-schelling/tere/commit/eba404900fb2fcf74f150d3ff97ce382bf1e34aa#comments for the discussion that lead up to this.
@mgunyho The first commit contains all feature relevant code. In the second commit I've updated the textwarp dependency, otherwise I'm not able to build master or this pr. error on master:
After updating textwarp I get a failing test both on main plus the second commit and for this pr.
RUST_BACKTRACE=1 cargo test --no-fail-fast --locked
:I guess this could be a rustc version mismatch but I'm not sure. What rustc version are you building against? Is this test working on master for you?