Open lgonzalez-silen opened 7 years ago
Not ignoring this. I'm in a bit of time crunch right now.
np! thanks
See the open PR referenced above. Since we use our large table extensively, it might still be good to update maxLookup for us (although probably very marginally), but in general the PR fixes the bug.
Hi,
Upon adding a new column to a table that was already large I started experiencing index out of range at
https://github.com/mgutz/dat/blob/v1/update.go#L178
It seems the condition that triggers hand off between preallocated parameter conversions and ad hoc conversions may be off by one. If I change
i < maxLookup
toi < maxLookup - 1
everything works fine but not sure if that's right, as the last element inequalsPlaceholderTab
will not be used. Also, is it right thatequalsPlaceholderTab
starts with$0
?I wrote a little snippet to test for various values of maxLookup (https://github.com/mgutz/dat/blob/v1/init.go#L19):
This breaks for
maxLookup <= 3
but works for larger values.Cheers,
Luis