search

mgutz / dat

Go Postgres Data Access Toolkit
Other
610 stars 62 forks source link

Wrapping guid.NewV4() to get prior behavior returning a single value. #77

Open pascallouisperez opened 6 years ago

pascallouisperez commented 6 years ago

Recently, the go.uuid library was modified to return a string, and an error when generating UUIDs. See [1]. For backwards compatibility, a Must func helper is provided which panics if there are any errors, reovering the prior behavior.

[1] https://github.com/satori/go.uuid/commit/0ef6afb2f6cdd6cdaeee3885a95099c63f18fc8c

pascallouisperez commented 6 years ago

Hey @mgutz, can you review?

pascallouisperez commented 6 years ago

Ping @mgutz!

keenan-v1 commented 6 years ago

@mgutz - Please accept this PR. While I love dat, failing to accept this PR breaks builds. (Hopefully the dep versioning coming will help us..)

If this is no longer being maintained, please notify so someone may fork and continue your great work.

pascallouisperez commented 6 years ago

We ended up forking given the lack of response.

See https://github.com/helloeave/dat

cc @xorith

Thanks @cbelsole for doing all the leg work!