search

mgwidmann / scrivener_html

HTML view helpers for Scrivener
MIT License
125 stars 208 forks source link

Phoenix dep, Application boundaries for Elixir 1.11.x #104

Open tmartin8080 opened 3 years ago

tmartin8080 commented 3 years ago

There are some application boundary warnings for Elixir 1.11.x and some other misc changes.

After updating, there were some failing tests which seem to be related to generating a tags:

 [60, "a", [[32, "class", 61, 34, "", 34]], 62, "1", 60, 47, "a", 62],
 [60, "a", [[32, "class", 61, 34, [], 34]], 62, "1", 60, 47, "a", 62],

I'll look more into this, but wanted to get a PR started.
Free to to chime in on what the implications of [] vs "" might be.