search

mgwidmann / scrivener_html

HTML view helpers for Scrivener
MIT License
125 stars 206 forks source link

SEO header links not taking non-existing pages into account #69

Open Sgoettschkes opened 6 years ago

Sgoettschkes commented 6 years ago

Thanks for the library and the whole scrivener libraries!

I have an issue with the header links generated by scrivener_html. If I am reading the code correctly there is currently no checking if the next/prev page does indeed exist?

In my opinion, checking if the next/prev pages exist (by looking the the total_pages in relation to the page_number) and skipping prev/next should do the trick. This would also mean the special cases for the first and last page at https://github.com/mgwidmann/scrivener_html/blob/master/lib/scrivener/html/seo.ex#L42 could be removed as they would be covered.

If you are ok with a PR regarding this I can look into it!

mgwidmann commented 6 years ago

Sorry I missed this. If you'd like to submit a PR, I'd be willing to merge and release it if is a bug like you describe. Thanks for reporting!

Sgoettschkes commented 6 years ago

I'll see to find some time to do the PR!

mgwidmann commented 5 years ago

Should we close this or do you still think this is a valuable addition?