Closed jaimeiniesta closed 2 years ago
is this project abandoned? Why is this not merged yet?
@mgwidmann scrivener pagination is really useful for our application but it's blocking us upgrading our application to phoenix 1.5. Can we get this merged in ?
Just sent @mgwidmann an email. Hopefully he responds and maybe we can get this merged in.
Any updates on this?
Noting that #98 is also trying to add support for Phoenix v1.5.x
Are there any updates on this? Still the blocker in upgrading to 1.5.x.....
@jaimeiniesta did you have good success just relaxing the dependencies, or is there more to be done?
The PR at https://github.com/mgwidmann/scrivener_html/pull/98/files shows that some tests had to be adapted, but nothing critical.
@thbar yes, I'm using my branch on a Phoenix 1.5.4 app and it works just fine:
{:phoenix, "~> 1.5.4"},
{:scrivener_ecto, "~> 2.5.0"},
{:scrivener_list, "~> 2.0.1"},
{:scrivener_html, github: "jaimeiniesta/scrivener_html", branch: "relax_phoenix_dep"}
@mgwidmann Anything preventing this from being merged?
PS.: For people upgrading to phoenix 1.5, just add override: true
in the meanwhile.
FYI, I am trying to spread the word in order to find a way to reach Matt, and maybe find a new team of maintainers (even just for simple stuff):
https://github.com/mgwidmann/scrivener_html/issues/103#issuecomment-924269872
Hello @jaimeiniesta! Can you confirm you are using this PR in production? Thanks!
@williamweckl you have approved the changes, but do you have merge rights on the repo?
@thbar yes, I'm using this PR in production with Phoenix 1.6.2, Elixir 1.12.3 and it works fine!
🎉 thanks!
Love to see this merged in!