mgwidmann / scrivener_html

HTML view helpers for Scrivener
MIT License
125 stars 208 forks source link

relax deps to allow phoenix 1.6 #97

Closed jaimeiniesta closed 2 years ago

jrissler commented 4 years ago

Love to see this merged in!

sushant12 commented 4 years ago

is this project abandoned? Why is this not merged yet?

blaza1 commented 4 years ago

@mgwidmann scrivener pagination is really useful for our application but it's blocking us upgrading our application to phoenix 1.5. Can we get this merged in ?

btbinhtran commented 4 years ago

Just sent @mgwidmann an email. Hopefully he responds and maybe we can get this merged in.

williamweckl commented 4 years ago

Any updates on this?

yellow5 commented 4 years ago

Noting that #98 is also trying to add support for Phoenix v1.5.x

benedikt7 commented 3 years ago

Are there any updates on this? Still the blocker in upgrading to 1.5.x.....

thbar commented 3 years ago

@jaimeiniesta did you have good success just relaxing the dependencies, or is there more to be done?

The PR at https://github.com/mgwidmann/scrivener_html/pull/98/files shows that some tests had to be adapted, but nothing critical.

jaimeiniesta commented 3 years ago

@thbar yes, I'm using my branch on a Phoenix 1.5.4 app and it works just fine:

{:phoenix, "~> 1.5.4"},
{:scrivener_ecto, "~> 2.5.0"},
{:scrivener_list, "~> 2.0.1"},
{:scrivener_html, github: "jaimeiniesta/scrivener_html", branch: "relax_phoenix_dep"}
thiagomajesk commented 3 years ago

@mgwidmann Anything preventing this from being merged?

PS.: For people upgrading to phoenix 1.5, just add override: true in the meanwhile.

thbar commented 3 years ago

FYI, I am trying to spread the word in order to find a way to reach Matt, and maybe find a new team of maintainers (even just for simple stuff):

https://github.com/mgwidmann/scrivener_html/issues/103#issuecomment-924269872

thbar commented 3 years ago

Hello @jaimeiniesta! Can you confirm you are using this PR in production? Thanks!

@williamweckl you have approved the changes, but do you have merge rights on the repo?

jaimeiniesta commented 3 years ago

@thbar yes, I'm using this PR in production with Phoenix 1.6.2, Elixir 1.12.3 and it works fine!

jaimeiniesta commented 2 years ago

🎉 thanks!