search

mgwidmann / scrivener_html

HTML view helpers for Scrivener
MIT License
125 stars 208 forks source link

Phoenix 1.5 #98

Open geofflane opened 4 years ago

geofflane commented 4 years ago

To use with the latest Phoenix, needed to update the dependencies. use Phoenix.ConnTest is deprecated. The HTML "AST" generated by the latest Phoenix HTML is different than previous, so had to change the tests, but confirm it worked. Not sure how you'd support multiple versions with these changes?

dbii commented 4 years ago

I think this should be have CI ran again, since it failed with a weird error on telemetry. I branched and did almost the same changes as this and my local tests pass (some mix packages may be a little more current in my fork).

thbar commented 3 years ago

This looks like a good candidate to fix #97. Any chance to get this merged? A lot of people have moved to Phoenix 1.5, so it would be greatly beneficial.

Any way we can help?