search

mgymrek / pybamview

Browser based application for viewing bam alignments
MIT License
56 stars 17 forks source link

Extend error thrown when no samples in BAM file #46

Closed fomightez closed 8 years ago

fomightez commented 8 years ago

This minor addition extends feedback associated with the error encountered by the user when it seems there are no samples in BAM file specified. Specifically, it adds information about read groups to make error thrown possibly more helpful and more consistent with the error seen when using --bamdir flag.

The encountered error of simply "No samples found in BAM file" had me scratching my head since tview worked with the indexed and sorted bam file I was trying to use. On a lark I tried with the --bamdir flag and got a more informative error mentioning "read groups", which I had not encoutered in the past when using tview or IGV or IGB. Minor thing, but others may appreciate the guidance.

mgymrek commented 8 years ago

Thanks for this! I agree, the message you added is much more informative