search

mgymrek / pybamview

Browser based application for viewing bam alignments
MIT License
56 stars 17 forks source link

Replace pyfasta with pyfaidx #47

Closed mdshw5 closed 8 years ago

mdshw5 commented 8 years ago

The work was very straightforward, however I haven't tested this. There should be no issues. Closes #37.

mgymrek commented 8 years ago

Thanks for doing this! Could you just change README.md to list pyfaidx as a requirement? Looks like now pysam is listed twice Also, could you just run maybe with the example files and a human reference genome to make sure this is working properly? Thanks!

mdshw5 commented 8 years ago
screen shot 2015-12-15 at 9 40 31 pm

Looks like there was one small tweak to get things working. Thanks for suggesting that I test first! Let me know if there's anything else to do!

mgymrek commented 8 years ago

Excellent, thanks for the PR!