mhaagens / react-mobx-react-router4-boilerplate

React, React-Router 4, MobX and Webpack 2-boilerplate with async routes.
560 stars 137 forks source link

Fix/webpack loaders #54

Closed luarmr closed 4 years ago

luarmr commented 6 years ago

I did a clean first execution and I got:

ERROR in ./node_modules/css-loader!./node_modules/postcss-loader/lib!./node_modules/resolve-url-loader!./node_modules/sass-loader/lib/loader.js?sourceMap!./src/styles/main.scss
Module not found: Error: Can't resolve 'file-loader' in '/Users/luarmr/Code/react-mobx-react-router4-boilerplate'
 @ ./node_modules/css-loader!./node_modules/postcss-loader/lib!./node_modules/resolve-url-loader!./node_modules/sass-loader/lib/loader.js?sourceMap!./src/styles/main.scss 6:10654-10701
 @ ./src/styles/main.scss
 @ ./src/index.js
 @ multi (webpack)-dev-server/client?http://0.0.0.0:3000 webpack/hot/dev-server react-hot-loader/patch webpack-dev-server/client?http://0.0.0.0:3000 webpack/hot/only-dev-server babel-polyfill whatwg-fetch ./src/index

I added manually the dependency. As result the yarn.lock got updated.

After this I got several warnings:

WARNING in ./src/images/reactrouter.png
(Emitted value instead of an instance of Error) DEPRECATED. Configure optipng's optimizationLevel option in its own options. (optipng.optimizationLevel)
 @ ./node_modules/css-loader!./node_modules/postcss-loader/lib!./node_modules/resolve-url-loader!./node_modules/sass-loader/lib/loader.js?sourceMap!./src/styles/main.scss 6:8689-8725
 @ ./src/styles/main.scss
 @ ./src/index.js
 @ multi (webpack)-dev-server/client?http://0.0.0.0:3000 webpack/hot/dev-server react-hot-loader/patch webpack-dev-server/client?http://0.0.0.0:3000 webpack/hot/only-dev-server babel-polyfill whatwg-fetch ./src/index

Fixed with the second commit, new options format.

y3n3rrr commented 6 years ago

this fixed for me too! thanks!

y3n3rrr commented 6 years ago

It fixed thanks!

From: Raul Martin [mailto:notifications@github.com] Sent: Wednesday, September 13, 2017 8:55 PM To: mhaagens/react-mobx-react-router4-boilerplate react-mobx-react-router4-boilerplate@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [mhaagens/react-mobx-react-router4-boilerplate] Fix/webpack loaders (#54)

I did a clean first execution and I got:

ERROR in ./node_modules/css-loader!./node_modules/postcss-loader/lib!./node_modules/resolve-url-loader!./node_modules/sass-loader/lib/loader.js?sourceMap!./src/styles/main.scss Module not found: Error: Can't resolve 'file-loader' in '/Users/luarmr/Code/react-mobx-react-router4-boilerplate' @ ./node_modules/css-loader!./node_modules/postcss-loader/lib!./node_modules/resolve-url-loader!./node_modules/sass-loader/lib/loader.js?sourceMap!./src/styles/main.scss 6:10654-10701 @ ./src/styles/main.scss @ ./src/index.js @ multi (webpack)-dev-server/client?http://0.0.0.0:3000 webpack/hot/dev-server react-hot-loader/patch webpack-dev-server/client?http://0.0.0.0:3000 webpack/hot/only-dev-server babel-polyfill whatwg-fetch ./src/index

I added manually the dependency. As result the yarn.lock got updated.

After this I got several warnings:

WARNING in ./src/images/reactrouter.png (Emitted value instead of an instance of Error) DEPRECATED. Configure optipng's optimizationLevel option in its own options. (optipng.optimizationLevel) @ ./node_modules/css-loader!./node_modules/postcss-loader/lib!./node_modules/resolve-url-loader!./node_modules/sass-loader/lib/loader.js?sourceMap!./src/styles/main.scss 6:8689-8725 @ ./src/styles/main.scss @ ./src/index.js @ multi (webpack)-dev-server/client?http://0.0.0.0:3000 webpack/hot/dev-server react-hot-loader/patch webpack-dev-server/client?http://0.0.0.0:3000 webpack/hot/only-dev-server babel-polyfill whatwg-fetch ./src/index

Fixed with the second commit, new options format.

PS: Thanks for this repo!!! very useful.


You can view, comment on, or merge this pull request online at:

https://github.com/mhaagens/react-mobx-react-router4-boilerplate/pull/54

Commit Summary

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mhaagens/react-mobx-react-router4-boilerplate/pull/54 , or mute the thread https://github.com/notifications/unsubscribe-auth/AWX9H_Ss98dQ7YOROzT6BcofEe46O_8mks5siBbxgaJpZM4PWfRL . https://github.com/notifications/beacon/AWX9Hx3Dvyt9Fxhmvvqf2-WiRBlccLCFks5siBbxgaJpZM4PWfRL.gif

luarmr commented 6 years ago

@mhaagens any thoughts?

mhaagens commented 6 years ago

This should be fixed by #54, could you please confirm?

luarmr commented 6 years ago

This is #54

luarmr commented 6 years ago

The error is fixed the warnings still there in master.