search

mhahsler / seriation

Infrastructure for Ordering using Seriation - R Package
GNU General Public License v3.0
75 stars 17 forks source link

The current evaluation of convergence settles on the first element #1

Closed cerebis closed 7 years ago

cerebis commented 7 years ago

The test for convergence will be evaluated only on the first element of the vectors emitted by rowSums and colSums. I have wrapped them in an all().

codecov-io commented 7 years ago

Codecov Report

Merging #1 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #1   +/-   ##
=======================================
  Coverage   39.72%   39.72%           
=======================================
  Files          56       56           
  Lines        3887     3887           
=======================================
  Hits         1544     1544           
  Misses       2343     2343
Impacted Files Coverage Δ
R/seriate_SPIN.R 10.2% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c870e14...051047c. Read the comment docs.

mhahsler commented 7 years ago

Bug fix for making matrix stochastic.

mhahsler commented 7 years ago

Hi Matthew,

Thank you for the bug fix.

-Michael