search

mhallsmoore / qstrader

QuantStart.com - QSTrader backtesting simulation engine.
https://www.quantstart.com/qstrader/
MIT License
2.93k stars 855 forks source link

Use Enum for Action #156

Closed femtotrader closed 4 years ago

femtotrader commented 7 years ago

Closes #155

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 66.646% when pulling a66a2f5445b46bf13ba0cc410aecb8f9ec4f9d95 on femtotrader:action_enum into 581ce49bdd665a10042f63e2c8be58320ba922d1 on mhallsmoore:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 66.646% when pulling a66a2f5445b46bf13ba0cc410aecb8f9ec4f9d95 on femtotrader:action_enum into 581ce49bdd665a10042f63e2c8be58320ba922d1 on mhallsmoore:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 66.646% when pulling a66a2f5445b46bf13ba0cc410aecb8f9ec4f9d95 on femtotrader:action_enum into 581ce49bdd665a10042f63e2c8be58320ba922d1 on mhallsmoore:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 66.646% when pulling de26e7ae95e023282df024963732c8cd43ac398a on femtotrader:action_enum into 581ce49bdd665a10042f63e2c8be58320ba922d1 on mhallsmoore:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.08%) to 66.646% when pulling de26e7ae95e023282df024963732c8cd43ac398a on femtotrader:action_enum into 581ce49bdd665a10042f63e2c8be58320ba922d1 on mhallsmoore:master.

mhallsmoore commented 4 years ago

Hi @femtotrader,

Thank you for the PR!

Given that the codebase has diverged somewhat since the previous version I'm going to close this without a merge.

If you feel that we can include an Action Enum in the current release I'd be happy to add that into a future version.

Kind regards,

Mike.