mhallsmoore / qstrader

QuantStart.com - QSTrader backtesting simulation engine.
https://www.quantstart.com/qstrader/
MIT License
2.88k stars 856 forks source link

trading_ig is not listed in requirements.txt #262

Closed OpenTrading closed 7 months ago

OpenTrading commented 6 years ago

In qstrader/price_handler/ig.py is an import of trading_ig from trading_ig.lightstreamer import Subscription but trading_ig is not listed in requirements.txt.

It's a little problematic: the version oof trading_ng on PyPi is old and importing it fails on one of Python 2.7 or 3.4 because of an infi.bunch issue, so you need to install trading_ig off of git hub where it uses munch. I've asked the trading_ng maintainer if he could push up a new release so that qstrader will run cleanly: https://github.com/ig-python/ig-markets-api-python-library/issues/54

I came across the error by running Sphinx to generate the apidoc mkdir doc cd doc sphinx-quickstart sphinx-apidoc -o source/ ../qstrader make html which imports all the files in the source to generate the rst. You might want to generate and checkin the Shpinx boilerplate so that people can build the apidoc easily, and you have a spot for project documentation; it will catch these import errors for you.

PS: If you're in at requirements.txt, could you consider changing all of the == to >= unless you know that that release has to be piined. For those of us not using virtualenv it makes life easier, and we get to take advantage of the improvements in the dependecies since the file was written. I did this for Python 2.7 and 3.4 and nothing seems to require the pins; some of the pins are getting quite old.