requirements: Don't use matplotlib==3.3.3

mhallsmoore / qstrader

QuantStart.com - QSTrader backtesting simulation engine.

https://www.quantstart.com/qstrader/

MIT License

2.84k stars 851 forks source link

requirements: Don't use matplotlib==3.3.3 #348

Closed b4d0n3 closed 3 years ago

b4d0n3 commented 3 years ago

Fixes: https://github.com/mhallsmoore/qstrader/issues/347

coveralls commented 3 years ago

Coverage remained the same at 69.804% when pulling 2dfd7aaa5b6f2e4616bf88d6b868c9a2692edcb2 on b4d0n3:wip-requirements-matplotlib-gridOn-error into e0d2ab1c0d2ab0470cfd7f298702537fd70617a6 on mhallsmoore:master.

mhallsmoore commented 3 years ago

Hi @b4d0n3,

Thanks for creating this PR. I'm happy with this as a temporary workaround.

I'll ensure going forward that the gridOn KeyError is fixed so as to allow newer versions of Matplotlib.

Cheers,

-Mike.