search

mhamadmahdialloush / uFVM

Learning the Finite Volume Method in CFD with MATLAB Programming
https://www.aub.edu.lb/msfea/research/Pages/cfd.aspx
128 stars 43 forks source link

A question in cfdAssembleStressTerm #23

Open liuqi45 opened 1 month ago

liuqi45 commented 1 month ago

Look at the code for calculating geoDiff_f In the 78 row,''n = cfdUnit(Sf);'' In the 79 row,''e = cfdUnit(CF);'' In the 81 row, ''CF_limited = max(dot(n',CF'), 0.05*cfdMag(CF)')';'' In the 84 row,''magCF = cfdMag(CF_limited);'' In the 105 row,''geoDiff_f = cfdMag(Ef)./magCF;''

I think the CF_limited is wrong, it should be ''CF_limited = max(dot(e',CF'), 0.05*cfdMag(CF)')';''

ruohai0925 commented 1 month ago

Hi @liuqi45 , it seems that the authors are not actively maintaining this repo now. I am also investigating this code these days. If you can send me an email to zdsjtu@gmail.com, maybe we can try to learn the codes together and exchange some experiences.