mhamadmahdialloush / uFVM

Learning the Finite Volume Method in CFD with MATLAB Programming
https://www.aub.edu.lb/msfea/research/Pages/cfd.aspx
136 stars 44 forks source link

test cases mentioned in the book 'the FVM in CFD' #8

Open zhanggh97 opened 3 years ago

zhanggh97 commented 3 years ago

In the book, the FVM in CFD, it says there is a set of basic test cases that can be used to learn how to setup and run problems using the code.

testAdvection.m testDiffusion.m testDiffusion01.m testDiffusion02.m testDiffusion03.m testDiffusion04.m testFlow01.m testFlow02.m testGradients.m testShearRate.m testSmithHutton.m testStepProfile.m testStepProfile2.m testTemperature.m testTransient.m testTurbulence.m

But I didn't find them in tutorals. I wonder where I can find these test cases, especially 'testTurbulence.m'.

mhamadmahdialloush commented 3 years ago

Hi, We have updated the tutorials since then. Please refer to the tutorial called flange instead. in the basic tutorials directory. It serves the same purpose as the old testDiffusion case. See also the stepProfile case, it is within the basic tutorials directory as well. Regards

On Tue, Oct 19, 2021 at 10:33 AM zhanggh97 @.***> wrote:

In the book, the FVM in CFD, it says there is a set of basic test cases that can be used to learn how to setup and run problems using the code.

testAdvection.m testDiffusion.m testDiffusion01.m testDiffusion02.m testDiffusion03.m testDiffusion04.m testFlow01.m testFlow02.m testGradients.m testShearRate.m testSmithHutton.m testStepProfile.m testStepProfile2.m testTemperature.m testTransient.m testTurbulence.m

But I didn't find them in tutorals. I wonder where I can find these test cases, especially 'testTurbulence.m'.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/mhamadAlloush/uFVM/issues/8, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFLISFND36LL4467G5PLYQ3UHUUNRANCNFSM5GIRHXDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

zhanggh97 commented 3 years ago

Thank you for your reply. So how about testTurbulence.m? Is there any tutorial for turbulence now?

mhamadmahdialloush commented 3 years ago

We did not include any turbulence in this code.

Regards

On Tue, Oct 19, 2021 at 1:48 PM zhanggh97 @.***> wrote:

Thank you for your reply. So how about testTurbulence.m? Is there any tutorial for turbulence now?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mhamadAlloush/uFVM/issues/8#issuecomment-946642913, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFLISFJCJTBN7PCFYMVA653UHVLJBANCNFSM5GIRHXDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

lichuanlong commented 2 years ago

In the book, chapter5 Exercise 2 Run testDiffusion (which is available as a test case with uFVM) for one iteration, then (a) Use ‘cfdGetCoefficients’ to get the global matrix data structure and compare it to that shown in Fig. 5.18. (b) Use cfdGetMesh to get a reference to the Mesh object and find the definition of a face, a cell and a vertex.

Where can we download testDiffusion case?

mhamadmahdialloush commented 2 years ago

The test cases have been changed since then. Refer please to the case flange in the basic directory in tutorials. This case is a pure diffusion case similar to the testDiffusion case, and it serves the same objective.

cesss commented 2 years ago

We did not include any turbulence in this code. Regards

So, when the appendix in the book mentions "testTurbulence.m", is it because that test case was actually incomplete and nonfunctional, or because it was working but it was removed? Given how complete and useful for learning uFVM is, it's a real pity that no turbulence support has been added. By doing a search for "turbulence" in the code, I get actually 11 hits, but most of them are case files setting "turbulence" to "off". Don't you have any preliminary implementation of some simple turbulence model in another repository? Thanks a lot!

mhamadmahdialloush commented 2 years ago

Hi,

The code provided in the book is an old baseline code, which we never used anymore. Just after the issuance of the book, we started a new uFVM project where we articulated the assembly procedure as well as linear solvers, in a very consistent manner, and that was the main target of the code, to be inline with the relevant book chapters. testTurbulence.m was one of the scripts among the old code, and is not anymore available in uFVM. Sorry for that.

Regards, Mahdi

cesss commented 2 years ago

Yes, I know it's not available in the current version of uFVM, but let me suggest that you provide the old code from some other place, because considering that the purpose of uFVM is to learn, it would be really helpful to take a look at how it was thought to implement turbulence in that old version. You can add it as a wish to the wishlist, if you prefer.