This project uses TTGO T-Call module to deal with calls and messages, monitor its surroundings and alert user via call or message if any environmental changes detected by ultrasound sensor.
[ ] The implementation fulfills the desired requirement.
Details
The code does the intended while also ensuring that it does not cause side-effects or compromise the system performance and functionality.
[ ] The code does not add unnecessary complexity.
Details
The code is neither too simple and long (over-engineering) nor too short and complex for peers. With a complex code, devs are likely to introduce bugs when calling or modifying the code.
[ ] The code is style guide compliant.
Details
The style guide of project is followed e.g. linting, formatting, types, and other standards. Any style point differing from the guide should not be combined with other changes, as it makes it hard to see what is being changed.
[ ] The code follows agreed design principles.
Details
SOLID principles are used efficiently, making the code reusable and scalable.
[ ] The code is readable.
Details
The code is readable and comprehensive. Comments are clear, useful, and explain why instead of what.
[ ] The code has appropriate tests.
Details
Tests should be added, as appropriate, in the same changelist as the code. Tests should be correct, sensible, and useful.
[ ] Documentation has been updated.
Details
Devs should update associated documentation. If code is deleted or deprecated, then the documentation should also be deleted.
Details
The code does the intended while also ensuring that it does not cause side-effects or compromise the system performance and functionality.Details
The code is neither too simple and long (over-engineering) nor too short and complex for peers. With a complex code, devs are likely to introduce bugs when calling or modifying the code.Details
The style guide of project is followed e.g. linting, formatting, types, and other standards. Any style point differing from the guide should not be combined with other changes, as it makes it hard to see what is being changed.Details
SOLID principles are used efficiently, making the code reusable and scalable.Details
The code is readable and comprehensive. Comments are clear, useful, and explain why instead of what.Details
Tests should be added, as appropriate, in the same changelist as the code. Tests should be correct, sensible, and useful.Details
Devs should update associated documentation. If code is deleted or deprecated, then the documentation should also be deleted.