search

mhamilton723 / FeatUp

Official code for "FeatUp: A Model-Agnostic Frameworkfor Features at Any Resolution" ICLR 2024
MIT License
1.34k stars 79 forks source link

Updating MANIFEST.in to include maskclip bpe vocab file. #63

Open opipari opened 3 months ago

opipari commented 3 months ago

Description

When installing the package using setuptools and pip, the vocabulary file required by maskclip (bpe_simple_vocab_16e6.txt.gz) is not included in the distribution package since it's not specified in the manifest file. This issue was also raised and described in #47. Trying to use the maskclip model after installing FeatUp currently results in a FileNotFoundError error for the missing vocabulary file.

Solution

This pull request makes three modifications to resolve the installation:

  1. Specify the vocabulary file as one to be installed along with python source files by listing bpe_simple_vocab_16e6.txt.gz in the MANIFEST.in file. [Link to line]
  2. Renaming manifest.in to MANIFEST.in so it is used by setuptools during the installation process.
  3. Setting the include_package_data flag to True within setup.py to ensure the manifest is used and the vocab file is installed. [Link to line]

Thanks

Thanks for considering this pull request and this awesome project!