search

mhammond / pywin32

Python for Windows (pywin32) Extensions
5.01k stars 793 forks source link

Change `mbcs` encoding to `utf-8` in `com/win32com/client` #2097

Closed Avasam closed 11 months ago

Avasam commented 1 year ago

https://github.com/mhammond/pywin32/pull/1990#discussion_r1288601998

[...] I suspect this is wrong now - when this file is being read I believe it will be assumed utf-8. Ditto the mbcs reference in build.py

- @mhammond

This changes more than what the initial comment mentioned, but I figured may as well review all usages of it. Even if we end up reverting because the needed changes would be too big or wrong.

Avasam commented 11 months ago

Thanks

Bumping this PR. This has been approved but not merged @mhammond