mhammond / pywin32

Python for Windows (pywin32) Extensions
5.01k stars 793 forks source link

adodbapi: Remove outdated and unused remote feature #2098

Closed Avasam closed 5 months ago

Avasam commented 1 year ago

See conversation in https://github.com/mhammond/pywin32/pull/2094

I don't think that the facility has ever been used by anyone other than myself, and the use case for that is now very outdated. I am in favor of dropping the entire subsystem as deprecated.

- @vernondcole

This PR removes the adodbapi.remote feature entirely, and properly cleans up all references to it. As well as now unused code and redundant conditions.

Avasam commented 6 months ago

I don't understand what is going on here, but I don't think that changes to 147 files is what you had in mind. I think that this PR is in error.

@vernondcole There's only 10 files changed. 3 of which are removal, and 1 is documentation. Are you confusing this with a different PR ?