search

mhammond / pywin32

Python for Windows (pywin32) Extensions
4.9k stars 783 forks source link

Improve markdown formatting for adodbapi #2210

Closed Avasam closed 3 months ago

Avasam commented 3 months ago

The adodbapi version of #2209

CC @vernondcole

vernondcole commented 3 months ago

This look great, and thank you for all the work! I have added two comments in-line. One is a broken link which should be excluded. The second is also a broken link, but it has an update to a different Microsoft page, so we can just change the link.

Avasam commented 3 months ago

Hi @vernondcole Thanks for the review! But I don't see your comments I suppose you are talking about https://asp101.com/articles/john/connstring/default.asp and http://www.microsoft.com/en-us/download/details.aspx?id=13255 . Although I don't know what's the new link.

vernondcole commented 3 months ago

Hmm. Github did not save them. I think my re-try may have worked better.

On Mon, Mar 18, 2024 at 10:27 PM Avasam @.***> wrote:

Hi @vernondcole https://github.com/vernondcole Thanks for the review! But I don't see your comments I suppose you are talking about https://asp101.com/articles/john/connstring/default.asp and https://www.microsoft.com/en-us/download/404-page . Which one should I remove and which one should I replace by what new link?

— Reply to this email directly, view it on GitHub https://github.com/mhammond/pywin32/pull/2210#issuecomment-2005731246, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAEZOBJM4Z2NMJZVI6FTG2TYY65DZAVCNFSM6AAAAABEY7SZD2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAMBVG4ZTCMRUGY . You are receiving this because you were mentioned.Message ID: @.***>