search

mhammond / pywin32

Python for Windows (pywin32) Extensions
5.08k stars 800 forks source link

Consistent usage of end-of-statement marker with macros (better clang-format out of the box) & Make the CI step actually fail on failure #2405

Open Avasam opened 1 month ago

Avasam commented 1 month ago

Closes #1412 Found with the regex #define .+?; (it may not find everything, but found a few) Alternatively, the ; can be removed from the macros themselves to force adding it in-code, not having to add any configuration (my instinct is to say that might be clearer for devs anyway, and removes specialized configuration, but up to you)

(I'll add an entry to the .git-blame-ignore-revs after its decided which solution you prefer)

Avasam commented 1 month ago

@mhammond Just to confirm before I add to the .git-blame-ignore: you prefer this config change over removing ; from the macro so that is has to be added when used in code?

mhammond commented 1 month ago

@mhammond Just to confirm before I add to the .git-blame-ignore: you prefer this config change over removing ; from the macro so that is has to be added when used in code?

I don't have a strong opinion here, but I think it kinda seems more natural for people to not use a trailing ; with macros. OTOH, with our checkers in place, maybe it is fine to start insisting on the ;.

WDYT?

Avasam commented 1 month ago

My gut feeling is that it would be nice not special case certain methods in configuration. It would also make usage more consistent (for example PYWIN_MODULE_INIT_RETURN_ERROR usage is followed by ; in 87/90 cases).

Avasam commented 1 week ago

It would also make usage more consistent (for example PYWIN_MODULE_INIT_RETURN_ERROR usage is followed by ; in 87/90 cases).

@mhammond This commit of this PR shows the difference: a0cab65 (#2405)